Comments on: Smarter Cleaner Gallery

By: Kaspars

Kaspars — Thu, 14 Jan 2010 16:59:26 +0000

Frank, the only problem I see with this approach is that it doesn't work with custom DB queries (when using query_posts();).

By: Frank

Frank — Thu, 14 Jan 2010 15:21:11 +0000

I think it better, when you parse before triggered wp_head; maybe this one:

add_action('the_posts', 'cleaner_gallery_head', 0);
function cleaner_gallery_head($posts) {
	if (empty($posts))
		return $posts;

	$found = false;

	foreach ($posts as $post) {
		if (stripos($post->post_content, '[gallery'))
			$found = true;
	}

	if ($found)
		wp_enqueue_style( 'cleaner-gallery', CLEANER_GALLERY_URL . '/cleaner-gallery.css', false, 0.7, 'all' );

	return $posts;
}

By: Kaspars

Kaspars — Thu, 14 Jan 2010 11:11:42 +0000

I have decided that, just like Ryan said, galleries are a core WordPress feature and their CSS should be provided by the theme. There is no easy way to tell what content is to be loaded for any particular view because of the way WordPress themes are constructed, especially in case of custom database queries. If your theme sticks to the standard loop, the best solution is to use Artem's solution.

By: Artem Russakovskii

Artem Russakovskii — Thu, 14 Jan 2010 08:03:47 +0000

Justin, that's exactly what I posted about today. See my first comment above.

By: Ryan

Ryan — Thu, 14 Jan 2010 02:30:31 +0000

Wouldn’t it make more sense to just require the theme to include the CSS? Using a separate stylesheet for this seems kinda pointless when the theme can presumably be styled to cope.

There was a trac ticket regarding this back in 2.5, but I’m guessing was ignored.

We should probably lobby to have this fixed in core as the current system produces some bizarro code. I don’t understand why a definition list would be used in this way for a gallery. Each line is no different from the next, so an unordered list or table seems far more sensible to me.

By: Justin Tadlock

Justin Tadlock — Thu, 14 Jan 2010 00:14:40 +0000

Yeah, I’m still looking into a solution for non-singular views. Once I, or anyone else, provides that, I can update the plugin.

By: Kaspars

Kaspars — Wed, 13 Jan 2010 20:37:37 +0000

Artem, you raise a very good point about the archive and index pages. I'll have to look into it.

By: Artem Russakovskii

Artem Russakovskii — Wed, 13 Jan 2010 19:40:23 +0000

Ha, incidentally, I posted a more in-depth look at the same issue of overincluding css and js by plugin authors at almost exactly the same time as you – http://beerpla.net/2010/01/13/.....the-posts/

Also, I’d be careful about your solution – it seems to assume a single post page only – what about galleries on the front page. Not everyone uses excerpts.